Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============3010404017272017642=="
MIME-Version: 1.0
Subject: Re: Review Request: CLOUDSTACK-297 Reset SSH key to access VM
 (Similar to
 reset password)
From: "Rohit Yadav" <bhaisaab@apache.org>
To: "Abhinandan Prateek" <aprateek@apache.org>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Harikrishna Patnala" <harikrishna.patnala@citrix.com>,
 "Rohit Yadav" <bhaisaab@apache.org>
Date: Thu, 10 Jan 2013 02:39:16 -0000
Message-ID: <20130110023916.2471.28229@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Rohit Yadav" <noreply@reviews.apache.org>
References: <20130109105158.2470.25543@reviews.apache.org>
In-Reply-To: <20130109105158.2470.25543@reviews.apache.org>
Reply-To: "Rohit Yadav" <bhaisaab@apache.org>

--===============3010404017272017642==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8905/#review15225
-----------------------------------------------------------


Holding on to this review until IP clearance issue is resolved, won't be sh=
ipped until PPMC gives thumbs up.
Meanwhile, the patch can be fixed such that it applies cleanly and does not=
 break anything on master. Thanks.

- Rohit Yadav


On Jan. 9, 2013, 10:51 a.m., Harikrishna Patnala wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8905/
> -----------------------------------------------------------
> =

> (Updated Jan. 9, 2013, 10:51 a.m.)
> =

> =

> Review request for cloudstack and Abhinandan Prateek.
> =

> =

> Description
> -------
> =

> A user VM can be associated with a SSH key pair while deploying that VM. =
A user can SSH into the VM using the SSH private Key. =

> using this feature we can reset that SSH key pair corresponding to that V=
M, i.e., to associate a new SSH key pair to the VM.
> =

> =

> This addresses bug CLOUDSTACK-297.
> =

> =

> Diffs
> -----
> =

>   api/src/com/cloud/api/commands/ResetSSHKeyCmd.java PRE-CREATION =

>   api/src/com/cloud/event/EventTypes.java e69e4a4 =

>   api/src/com/cloud/network/element/UserDataServiceProvider.java 321ccc7 =

>   api/src/com/cloud/vm/UserVmService.java 98d02db =

>   client/tomcatconf/commands.properties.in 1e70c0f =

>   server/src/com/cloud/network/NetworkManager.java ef0d4c5 =

>   server/src/com/cloud/network/NetworkManagerImpl.java f7189df =

>   server/src/com/cloud/network/element/CloudZonesNetworkElement.java ae8b=
e0d =

>   server/src/com/cloud/network/element/VirtualRouterElement.java 4ff1082 =

>   server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java=
 2980871 =

>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.=
java fcba6df =

>   server/src/com/cloud/vm/UserVmManagerImpl.java 9356048 =

>   server/test/com/cloud/network/MockNetworkManagerImpl.java 0b83f35 =

>   server/test/com/cloud/vm/MockUserVmManagerImpl.java 35ee139 =

>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 824e40d =

> =

> Diff: https://reviews.apache.org/r/8905/diff/
> =

> =

> Testing
> -------
> =

> I did the manual testing
> - Reset SSH keys for VM  already having SSH key
> - Reset SSH keys for VM  created from password enabled template and alrea=
dy having SSH key =

> - Reset SSH keys for VM  having no SSH key
> - Reset SSH keys for VM  created from password enabled template and have =
no previous SSH key
> - Reset SSH keys for VM  already having SSH key when VM is in running sta=
te
> - Reset SSH keys for VM  created from password enabled template and alrea=
dy having SSH key  and VM is in running state
> =

> =

> Thanks,
> =

> Harikrishna Patnala
> =

>


--===============3010404017272017642==--