incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-1080) Interface heirarchy for AccountManagerImpl superflous
Date Thu, 31 Jan 2013 21:07:13 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-1080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Rohit Yadav resolved CLOUDSTACK-1080.
-------------------------------------

    Resolution: Fixed

Thanks for the new patch, applied on master. I would still want to refactor accountmanager
and service, clean the code;

commit 44d1397d367cf8aae7daa40efe11489fd1eee9ad
Author: joesan <codeintheopen@gmail.com>
Date:   Thu Jan 31 19:23:36 2013 +0100

    fix CS-1080
                
> Interface heirarchy for AccountManagerImpl superflous
> -----------------------------------------------------
>
>                 Key: CLOUDSTACK-1080
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1080
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: API
>            Reporter: Joe San
>            Assignee: Rohit Yadav
>            Priority: Trivial
>              Labels: Refactoring
>
> The AccountManagerImpl.java has two interfaces in its implements clause which is a bit
redundant. These two interfaces are already in the same heirarchy (AccountManager and AccountService).
Can we refactor the AccountManagerImpl to implement only the AccountManager?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message