incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chip Childers (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CLOUDSTACK-933) CglibThrowableRendererTest writing stack traces to terminal
Date Fri, 11 Jan 2013 22:16:12 GMT

     [ https://issues.apache.org/jira/browse/CLOUDSTACK-933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Chip Childers resolved CLOUDSTACK-933.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.1.0
         Assignee: Noa Resare

Reviewboard patch committed to master:

commit 1033200b0b5943cc21d5397d12d3b54b69aa2273
Author: Noa Resare <noa@spotify.com>
Date:   Wed Jan 9 16:39:10 2013 +0100

    CLOUDSTACK-933: CglibThrowableRendererTest writing stack traces...
    
    Improve CglibThrowableRenderer test case
    
    Log to a separate Logger instead of the default one to avoid spurious
    stack traces in test run output.
    
    Actually verify that registering CglibThrowableRenderer with the
    alternative log hierarchy actually removes call trace lines that
    contains the string <generated>
                
> CglibThrowableRendererTest writing stack traces to terminal
> -----------------------------------------------------------
>
>                 Key: CLOUDSTACK-933
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-933
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>            Reporter: Noa Resare
>            Assignee: Noa Resare
>            Priority: Minor
>             Fix For: 4.1.0
>
>
> The test case in CglibThrowableRendererTest writes some scary looking stack traces to
the build log via the ConsoleAppender. Moreover it doesn't actually test anything. I suppose
the functionality of the code to be tested can be manually verified via the console output,
but that's not really in the spirit of automated unit testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message