incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Min Chen <min.c...@citrix.com>
Subject Re: Review Request: [API] ListTemplates API is not returning "Enable SSH Key" attribute for any given template
Date Wed, 09 Jan 2013 19:43:05 GMT
Thanks for the tip. I will use that command next time.

-min

On 1/9/13 11:39 AM, "Rohit Yadav" <rohit.yadav@citrix.com> wrote:

>Hi Min, 
>
>Thanks for the review and commit. But in future please use the git commit
>--author=<author name, email signature> or better use git am <patch> (now
>that reviewboard does not strip author info, sig, commit msg etc.), this
>is so that the commit reflects author's signature and we give them credit
>for their work.
>
>Regards.
>________________________________________
>From: Min Chen [noreply@reviews.apache.org] On Behalf Of Min Chen
>[min.chen@citrix.com]
>Sent: Thursday, January 10, 2013 12:15 AM
>To: Min Chen; Alena Prokharchyk
>Cc: cloudstack; Likitha Shetty
>Subject: Re: Review Request: [API] ListTemplates API is not returning
>"Enable SSH Key" attribute for any given template
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>https://reviews.apache.org/r/8546/#review15201
>-----------------------------------------------------------
>
>Ship it!
>
>
>Committed to master.
>
>- Min Chen
>
>
>On Jan. 9, 2013, 6:31 a.m., Likitha Shetty wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/8546/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 9, 2013, 6:31 a.m.)
>>
>>
>> Review request for cloudstack, Alena Prokharchyk and Min Chen.
>>
>>
>> Description
>> -------
>>
>> Update the TemplateResponse by adding 'sshkeyenabled' attribute to it.
>>This attribute is set to the value that the user passes as input for
>>parameter 'sshkeyenabled' while registering the template.
>>
>>
>> This addresses bug CLOUDSTACK-614.
>>
>>
>> Diffs
>> -----
>>
>>   api/src/org/apache/cloudstack/api/response/TemplateResponse.java
>>f6f74da
>>   server/src/com/cloud/api/ApiResponseHelper.java 37be83e
>>
>> Diff: https://reviews.apache.org/r/8546/diff/
>>
>>
>> Testing
>> -------
>>
>> Called API command=listTemplates&listall=true&templatefilter=featured
>> The JSON response contained a boolean SSH related attribute called
>>'sshkeyenabled' which mentioned if the template is SSH enabled or not.
>>
>>
>> Thanks,
>>
>> Likitha Shetty
>>
>>
>


Mime
View raw message