incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rohit Yadav <rohit.ya...@citrix.com>
Subject Re: Review Request: BigSwitch VNS Networking Plugin
Date Thu, 31 Jan 2013 02:09:05 GMT
Hi Kanzhe,

Just go through that wiki and see other apis how annotation is used,
and add/edit anything missing as well.
You may want to test your apis and make sure they work. Feel free to
reach out to me for any help regarding apis.

Regards.

On Wed, Jan 30, 2013 at 4:51 PM, Chiradeep Vittal
<Chiradeep.Vittal@citrix.com> wrote:
> @EntityReference(FirewallRule.class)
>
> The IdentityProxy is deprecated.
>
> It looks like you have not rebased to the latest master.
>
> See this guide
> https://cwiki.apache.org/confluence/x/0wDFAQ
>
> On 1/30/13 4:20 PM, "Kanzhe Jiang" <kanzhe.jiang@bigswitch.com> wrote:
>
>>Chiradeep,
>>
>>I do not see any annotation referring to the table
>>in FirewallRuleResponse.java.
>>What am I missing here?
>>
>>Kanzhe
>>
>>On Wed, Jan 30, 2013 at 3:33 PM, Chiradeep Vittal <
>>Chiradeep.Vittal@citrix.com> wrote:
>>
>>> Any subclass of BaseResponse.
>>> For example, FirewallRuleResponse
>>>
>>> On 1/30/13 11:14 AM, "Kanzhe Jiang" <kanzhe.jiang@bigswitch.com> wrote:
>>>
>>> >Hi Chiradeep,
>>> >
>>> >Thank you for your review comments. I resolved all but one of your
>>> >comments
>>> >and need some clarification on
>>> >"Requires an annotation referring to the table"
>>> >
>>> >Is there any example that I can refer to?
>>> >
>>> >Thanks,
>>> >Kanzhe
>>> >
>>> >On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang
>>> ><kanzhe.jiang@bigswitch.com>wrote:
>>> >
>>> >>    This is an automatically generated e-mail. To reply, visit:
>>> >> https://reviews.apache.org/r/9131/
>>> >>   Review request for cloudstack.
>>> >> By Kanzhe Jiang.
>>> >>
>>> >> *Updated Jan. 30, 2013, 4:12 a.m.*
>>> >> Changes
>>> >>
>>> >> Updated patch based on review comments.
>>> >>
>>> >>   Description
>>> >>
>>> >> This is the first patch for BigSwitch Network Plugin to CloudStack.
>>>The
>>> >>patch follows the design spec that can be found at
>>> >>
>>>
>>>https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networki
>>> >>ng+Plugin.
>>> >>
>>> >>   Testing
>>> >>
>>> >> Verify the builds: mvn clean install;
>>> >> The database can be deployed;
>>> >> CloudStack can be launched with the plugin modules.
>>> >>
>>> >> JUnit tests of all api commands to a mock controller.
>>> >>
>>> >>
>>> >>   Diffs (updated)
>>> >>
>>> >>    - api/src/com/cloud/api/ApiConstants.java (78a3ded)
>>> >>    - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
>>> >>    - build/build-cloud-plugins.xml (207ef71)
>>> >>    - build/developer.xml (fdda171)
>>> >>    - client/pom.xml (1673429)
>>> >>    - client/tomcatconf/bigswitch-vns_commands.properties.in
>>> >>(PRE-CREATION)
>>> >>    - client/tomcatconf/components.xml.in (5957b61)
>>> >>    - cloud.spec (9f46dd6)
>>> >>    - debian/cloud-server.install (9cd1eeb)
>>> >>    - docs/en-US/Release_Notes.xml (c8cc686)
>>> >>    - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sN
>>> >>etworkAnswer.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sN
>>> >>etworkCommand.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sP
>>> >>ortAnswer.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVn
>>>>>sP
>>> >>ortCommand.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sN
>>> >>etworkAnswer.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sN
>>> >>etworkCommand.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sP
>>> >>ortAnswer.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVn
>>>>>sP
>>> >>ortCommand.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupB
>>>>>ig
>>> >>SwitchVnsCommand.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVn
>>>>>sP
>>> >>ortAnswer.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVn
>>>>>sP
>>> >>ortCommand.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBi
>>>>>gS
>>> >>witchVnsDeviceCmd.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/Delet
>>>>>eB
>>> >>igSwitchVnsDeviceCmd.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListB
>>>>>ig
>>> >>SwitchVnsDevicesCmd.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsCo
>>>>>ns
>>> >>tants.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSw
>>>>>it
>>> >>chVnsDeviceResponse.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchV
>>>>>ns
>>> >>DeviceVO.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>At
>>> >>tachment.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Bi
>>> >>gSwitchVnsApi.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Bi
>>> >>gSwitchVnsApiException.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Co
>>> >>ntrolClusterStatus.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Ne
>>> >>twork.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/
>>>>>Po
>>> >>rt.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwi
>>>>>tc
>>> >>hVnsDao.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwi
>>>>>tc
>>> >>hVnsDaoImpl.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/Bi
>>>>>gS
>>> >>witchVnsElement.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/Bi
>>>>>gS
>>> >>witchVnsElementService.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSw
>>>>>it
>>> >>chVnsGuestNetworkGuru.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/B
>>>>>ig
>>> >>SwitchVnsResource.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch
>>>>>/B
>>> >>igSwitchApiTest.java
>>> >>    (PRE-CREATION)
>>> >>    -
>>>
>>>>>plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/
>>>>>Bi
>>> >>gSwitchVnsResourceTest.java
>>> >>    (PRE-CREATION)
>>> >>    - plugins/pom.xml (2009302)
>>> >>    - server/src/com/cloud/network/NetworkManager.java (057f473)
>>> >>    - setup/db/create-schema.sql (fff084e)
>>> >>    - tools/apidoc/gen_toc.py (eeaf2a2)
>>> >>    - tools/apidoc/pom.xml (b75ee82)
>>> >>    - wscript_configure (3b9377b)
>>> >>
>>> >> View Diff <https://reviews.apache.org/r/9131/diff/>
>>> >>
>>> >
>>> >
>>> >
>>> >--
>>> >Kanzhe Jiang
>>> >MTS at BigSwitch
>>>
>>>
>>
>>
>>--
>>Kanzhe Jiang
>>MTS at BigSwitch
>

Mime
View raw message