incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kanzhe Jiang <kanzhe.ji...@bigswitch.com>
Subject Re: Review Request: BigSwitch VNS Networking Plugin
Date Wed, 30 Jan 2013 19:14:08 GMT
Hi Chiradeep,

Thank you for your review comments. I resolved all but one of your comments
and need some clarification on
"Requires an annotation referring to the table"

Is there any example that I can refer to?

Thanks,
Kanzhe

On Tue, Jan 29, 2013 at 8:12 PM, Kanzhe Jiang <kanzhe.jiang@bigswitch.com>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9131/
>   Review request for cloudstack.
> By Kanzhe Jiang.
>
> *Updated Jan. 30, 2013, 4:12 a.m.*
> Changes
>
> Updated patch based on review comments.
>
>   Description
>
> This is the first patch for BigSwitch Network Plugin to CloudStack. The patch follows
the design spec that can be found at https://cwiki.apache.org/confluence/display/CLOUDSTACK/BigSwitch+Networking+Plugin.
>
>   Testing
>
> Verify the builds: mvn clean install;
> The database can be deployed;
> CloudStack can be launched with the plugin modules.
>
> JUnit tests of all api commands to a mock controller.
>
>
>   Diffs (updated)
>
>    - api/src/com/cloud/api/ApiConstants.java (78a3ded)
>    - api/src/com/cloud/network/PhysicalNetwork.java (be4b1d0)
>    - build/build-cloud-plugins.xml (207ef71)
>    - build/developer.xml (fdda171)
>    - client/pom.xml (1673429)
>    - client/tomcatconf/bigswitch-vns_commands.properties.in (PRE-CREATION)
>    - client/tomcatconf/components.xml.in (5957b61)
>    - cloud.spec (9f46dd6)
>    - debian/cloud-server.install (9cd1eeb)
>    - docs/en-US/Release_Notes.xml (c8cc686)
>    - plugins/network-elements/bigswitch-vns/pom.xml (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkAnswer.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsNetworkCommand.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortAnswer.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/CreateVnsPortCommand.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkAnswer.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsNetworkCommand.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortAnswer.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/DeleteVnsPortCommand.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/StartupBigSwitchVnsCommand.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortAnswer.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/agent/api/UpdateVnsPortCommand.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/AddBigSwitchVnsDeviceCmd.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/DeleteBigSwitchVnsDeviceCmd.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/ListBigSwitchVnsDevicesCmd.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/api/commands/VnsConstants.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/api/response/BigSwitchVnsDeviceResponse.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/BigSwitchVnsDeviceVO.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Attachment.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApi.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/BigSwitchVnsApiException.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/ControlClusterStatus.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Network.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/bigswitch/Port.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDao.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/dao/BigSwitchVnsDaoImpl.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElement.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/element/BigSwitchVnsElementService.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/guru/BigSwitchVnsGuestNetworkGuru.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/src/com/cloud/network/resource/BigSwitchVnsResource.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/test/com/cloud/network/bigswitch/BigSwitchApiTest.java
>    (PRE-CREATION)
>    - plugins/network-elements/bigswitch-vns/test/com/cloud/network/resource/BigSwitchVnsResourceTest.java
>    (PRE-CREATION)
>    - plugins/pom.xml (2009302)
>    - server/src/com/cloud/network/NetworkManager.java (057f473)
>    - setup/db/create-schema.sql (fff084e)
>    - tools/apidoc/gen_toc.py (eeaf2a2)
>    - tools/apidoc/pom.xml (b75ee82)
>    - wscript_configure (3b9377b)
>
> View Diff <https://reviews.apache.org/r/9131/diff/>
>



-- 
Kanzhe Jiang
MTS at BigSwitch

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message