incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: Review Request: Hyper-V 2012 Plugin Phase 1
Date Mon, 28 Jan 2013 22:18:42 GMT
It should have been the base diff, not an attachment.  Otherwise we
can't use reviewboard to actually review the changes.

On Mon, Jan 28, 2013 at 5:12 PM, Donal Lafferty
<donal.lafferty@citrix.com> wrote:
> The patch was add as a file attachment.
>
> Is that the correct procedure?
>
> DL
>
>> -----Original Message-----
>> From: Donal Lafferty [mailto:noreply@reviews.apache.org] On Behalf Of
>> Donal Lafferty
>> Sent: 28 January 2013 21:56
>> To: Chip Childers; Alex Huang
>> Cc: cloudstack; Donal Lafferty
>> Subject: Re: Review Request: Hyper-V 2012 Plugin Phase 1
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/9126/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 28, 2013, 9:56 p.m.)
>>
>>
>> Review request for cloudstack, Chip Childers and Alex Huang.
>>
>>
>> Description
>> -------
>>
>> First cut of HyperV plugin, cloud-api changes to support VHDX image type,
>> and test changes to deal with Windows clock accuracy and URI semantics.
>> Large size due to inclusion of a disk image used for some of the unit testing.
>> Not all unit test dependencies in place.  I'd rather download image files from
>> a source than add them to the repo, but haven't found a link for this yet.
>>
>>
>> This addresses bug CLOUDSTACK-999.
>>
>>
>> Diffs
>> -----
>>
>>
>> Diff: https://reviews.apache.org/r/9126/diff/
>>
>>
>> Testing
>> -------
>>
>>
>> Thanks,
>>
>> Donal Lafferty
>

Mime
View raw message