incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject Re: Review Request: Work around maven dependency problems
Date Fri, 04 Jan 2013 15:57:23 GMT
On Fri, Jan 4, 2013 at 4:08 AM, Noa Resare <noa@spotify.com> wrote:
> This is nice. I go to bed and when I wake up a bug in jira has been created
> and my patch has been merged. Thanks a lot.
>
> Someone with write access to
> http://incubator.apache.org/cloudstack/develop/non-contributors.html might
> want to add a note about creating a jira issue for your patch.

Done.  And thanks again for your patch submission!

> /n
>
>
> On Fri, Jan 4, 2013 at 7:15 AM, Prasanna Santhanam <
> Prasanna.Santhanam@citrix.com> wrote:
>
>>
>>
>> > On Jan. 4, 2013, 6:14 a.m., Prasanna Santhanam wrote:
>> > > Ship It!
>>
>> commit 42f3804fbdde7bfe4f3676ef0c18a54dfe95354c
>> Author: Noa Resare <noa@spotify.com>
>> Date:   Thu Jan 3 15:48:06 2013 +0000
>>
>>     Work around maven dependency problems
>>
>>     Disable the transitive dependency from axis2-webapp to xercesImpl
>>     and from all rampart artifacts to opensaml. This fixes reproducible
>>     problem where maven tries to download artifacts from the wrong
>>     repositories.
>>
>>     Signed-off-by: Prasanna Santhanam <tsp@apache.org>
>>     Signed-off-by: Rohit Yadav <bhaisaab@apache.org>
>>     Reviewed-by: Likitha Shetty <Likitha.Shetty@citrix.com>
>>
>>
>> - Prasanna
>>
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/8809/#review15068
>> -----------------------------------------------------------
>>
>>
>> On Jan. 3, 2013, 5:46 p.m., Noa Resare wrote:
>> >
>> > -----------------------------------------------------------
>> > This is an automatically generated e-mail. To reply, visit:
>> > https://reviews.apache.org/r/8809/
>> > -----------------------------------------------------------
>> >
>> > (Updated Jan. 3, 2013, 5:46 p.m.)
>> >
>> >
>> > Review request for cloudstack.
>> >
>> >
>> > Description
>> > -------
>> >
>> > Oh maven *sigh*. The combination of a system of transitive dependencies
>> and the ability of pom files to inject (broken) repository information into
>> the lookup process sometimes result in a situation where maven attempts to
>> download artefacts from the wrong server.  This typically happens over and
>> over again and slows down maven runs significantly.
>> >
>> > This is even more annoying when the artefacts downloaded most certainly
>> isn't used.
>> >
>> > The attached patch fixes three such problems that I can reproduce
>> locally. The pattern of adding excludes elements to maven dependency
>> references is already used in cloudstack. Newer versions of the
>> dependencies removed are added in other ways to the cloudstack dependency
>> graph.
>> >
>> >
>> > Diffs
>> > -----
>> >
>> >   awsapi/pom.xml 2e42655
>> >
>> > Diff: https://reviews.apache.org/r/8809/diff/
>> >
>> >
>> > Testing
>> > -------
>> >
>> >
>> > Thanks,
>> >
>> > Noa Resare
>> >
>> >
>>
>>
>
>
> --
> Engineering Experience, Infrastructure tribe, Spotify

Mime
View raw message