incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chiradeep Vittal" <chirade...@gmail.com>
Subject Re: Review Request: A minor refacotoring to the AccountManagerImpl.java to remove the superfluous interface implements
Date Thu, 31 Jan 2013 18:13:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9152/#review15948
-----------------------------------------------------------


Having done this with the previous version of NetworkManagerImpl, I agree that it is not as
trivial as removing the implements clause. The proper fix is to have separated implementations
of AccountService and AccountManager

- Chiradeep Vittal


On Jan. 30, 2013, 6:32 a.m., Joe San wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9152/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 6:32 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Removed the superfluous interfaces in the implements clause in the AccountManagerImpl.java.
The @Local annotation specifies the interfaces and this is enough.
> 
> 
> This addresses bug CLOUDSTACK-1080.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/user/AccountManagerImpl.java b910a03 
> 
> Diff: https://reviews.apache.org/r/9152/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joe San
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message