incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request: CLOUDSTACK-446: Host going to alert state, if you are adding already added host
Date Thu, 31 Jan 2013 12:34:27 GMT


> On Jan. 29, 2013, 9:11 a.m., Abhinandan Prateek wrote:
> > Ship It!

There are merge conflicts. 
Koushik,
  Can you check if this is required now ?


- Abhinandan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7891/#review15792
-----------------------------------------------------------


On Nov. 6, 2012, 6:41 a.m., Koushik Das wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7891/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2012, 6:41 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Alex Huang.
> 
> 
> Description
> -------
> 
> Adding an already added host fails with error but in the process incorrectly updates
the status of the host to 'Alert'. Have put a check to prevent this.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/resource/ResourceManagerImpl.java ced601b 
> 
> Diff: https://reviews.apache.org/r/7891/diff/
> 
> 
> Testing
> -------
> 
> Steps to repro
> 1. Created a vmware cluster and added a host, verify that the status shows as 'Up'
> 2. Added the same host again, fails with error
> 3. Refresh the host page in MS UI to verify that host status chages to 'Alert' from 'Up'
> 
> After applying the fix follow the same repro steps and verify that the host status doesn't
change to 'Alert'.
> 
> 
> Thanks,
> 
> Koushik Das
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message