incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Tripathi" <sanjay.tripa...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-713 Limit Resources to domain/accounts
Date Tue, 29 Jan 2013 07:45:18 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9110/
-----------------------------------------------------------

(Updated Jan. 29, 2013, 7:45 a.m.)


Review request for cloudstack.


Changes
-------

Updated the patch as per Nitin's comments.
Also added the new resource types (CPU and Memory) in the account_view schema which will reflect
in the listaccounts response.


Description
-------

CLOUDSTACK-713: Limit Resources to domain/accountsi(CPU and RAM)
    
    Addition of two new resource types i.e. CPU and RAM in the existing pool of
    resource types.
    Added some methods to set the limits on these resources using updateResource
    API command and to get a count using updateResourceCount. Also added calls in
    Virtual machine life cycle to check these limits and to increment/decrement 
    resource count
    
    Resource Name  :: Resource type number
        CPU               8
        RAM               9


This addresses bug CLOUDSTACK-713.


Diffs (updated)
-----

  api/src/com/cloud/configuration/Resource.java 7f551d6 
  api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceCountCmd.java 4aa694b

  api/src/org/apache/cloudstack/api/command/user/resource/UpdateResourceLimitCmd.java 9b6359f

  api/src/org/apache/cloudstack/api/response/AccountResponse.java 51d3352 
  api/src/org/apache/cloudstack/api/response/ResourceCountResponse.java 7a29194 
  api/src/org/apache/cloudstack/api/response/ResourceLimitResponse.java c01e12f 
  server/src/com/cloud/api/query/dao/AccountJoinDaoImpl.java 6268724 
  server/src/com/cloud/api/query/vo/AccountJoinVO.java 6d37f4d 
  server/src/com/cloud/baremetal/BareMetalVmManagerImpl.java 57cfb39 
  server/src/com/cloud/configuration/Config.java 4ae144e 
  server/src/com/cloud/resourcelimit/ResourceLimitManagerImpl.java c17b0ea 
  server/src/com/cloud/vm/UserVmManagerImpl.java ecf1242 
  server/test/com/cloud/resourcelimit/ResourceLimitManagerImplTest.java PRE-CREATION 
  server/test/com/cloud/vpc/MockResourceLimitManagerImpl.java a0c7b70 
  setup/db/db/schema-40to410.sql ed4946e 

Diff: https://reviews.apache.org/r/9110/diff/


Testing
-------

Manually tested on my local CloudStack setup. Also added unit tests file in the patch.


Thanks,

Sanjay Tripathi


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message