incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Nalley" <da...@gnsa.us>
Subject Re: Review Request: Fix for CLOUDSTACK-1050 (No section for Adding Load Balancer Rule)
Date Mon, 28 Jan 2013 15:19:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9097/#review15748
-----------------------------------------------------------


This does not apply for me. 

[ke4qqq@mba docs]$ git am foo.patch
Applying: fix for CLOUDSTACK-1048
error: patch failed: docs/en-US/sticky-session-policies-for-lb-rules.xml:3
error: docs/en-US/sticky-session-policies-for-lb-rules.xml: patch does not apply
Patch failed at 0001 fix for CLOUDSTACK-1048
The copy of the patch that failed is found in:
   /home/ke4qqq/Documents/apache/cloudstack/incubator-cloudstack/.git/rebase-apply/patch
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".


Almost as if it were generated off of a different copy of the files in question since this
is a simple two file patch. 
You are basing your work in master, right? 
This review is only three days old, and afaict, no one has touched the two files in question
in the past week. 

--David

- David Nalley


On Jan. 24, 2013, 11:16 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9097/
> -----------------------------------------------------------
> 
> (Updated Jan. 24, 2013, 11:16 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Jessica Tomechak, and Joe Brockmeier.
> 
> 
> Description
> -------
> 
> Documentation on Adding a Load Balancer Rule and Sticky Session Policies for Load Balancer
Rules
> 
> 
> This addresses bug CLOUDSTACK-1050.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/load-balancer-rules.xml 8dd7d3b 
>   docs/en-US/sticky-session-policies-for-lb-rules.xml a8acfa0 
> 
> Diff: https://reviews.apache.org/r/9097/diff/
> 
> 
> Testing
> -------
> 
> Patch applies,
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message