incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Nalley" <da...@gnsa.us>
Subject Re: Review Request: vSphere / ESXi patch installation procedure
Date Mon, 28 Jan 2013 15:11:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9122/#review15747
-----------------------------------------------------------

Ship it!


This builds and is a good addition. I've added some feedback for one of my concerns, but it
isn't something that I think blocks this patch. I tested all of the docs after applying this
patch - and have pushed it to master. 

commit b56f7b26e2bf8d41421278d5be753a157a3a01b2
Author: Radhika PC <radhika.puthiyetath@citrix.com>
Date:   Mon Jan 28 13:00:57 2013 +0530

    CLOUDSTACK-399
    
    Signed-off-by: Radhika PC <radhika.puthiyetath@citrix.com>

I'll close this review as submitted. 

Thanks

--David


docs/en-US/vmware-install.xml
<https://reviews.apache.org/r/9122/#comment33904>

    I am somewhat concerned about the terms 'Disconnected', 'unmanaged' and 'maintenance mode'
seemingly being used interchangably. 


- David Nalley


On Jan. 28, 2013, 7:45 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9122/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 7:45 a.m.)
> 
> 
> Review request for cloudstack, sudha ponnaganti, Chip Childers, Jessica Tomechak, and
Joe Brockmeier.
> 
> 
> Description
> -------
> 
> vSphere / ESXi patch installation procedure
> 
> 
> This addresses bug CLOUDSTACK-399.
> 
> 
> Diffs
> -----
> 
>   docs/en-US/vmware-install.xml 736b122 
> 
> Diff: https://reviews.apache.org/r/9122/diff/
> 
> 
> Testing
> -------
> 
> Install Guide builds without errors. Patch applies.
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message