incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: make maven use mkisofs or genisoimage depending on what is available
Date Sun, 27 Jan 2013 12:50:00 GMT


> On Jan. 27, 2013, 12:49 p.m., Rohit Yadav wrote:
> > Ship It!

Committed on master, closing review as submitted;

commit 7d40a7e500f5451e2c450e30fa520bc278ded088
Author: Noa Resare <noa@spotify.com>
Date:   Sun Jan 27 04:48:47 2013 -0800

    Make maven use mkisofs or genisoimage depending on what is available


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8838/#review15737
-----------------------------------------------------------


On Jan. 4, 2013, 11:51 p.m., Noa Resare wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8838/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 11:51 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Due to differing licensing philosophies between the Debian project and the mkisofs maintainer
the tool will probably never be shipped as part of Debian. 
> 
> There is a tool named genisoimage that is command line parameter compatible with mkisofs
and does the same thing. 
> 
> The attached patch uses the maven profile system to parameterize the binary used to generate
iso files depending on what is available on the system.
> 
> 
> This addresses bug CLOUDSTACK-792.
> 
> 
> Diffs
> -----
> 
>   console-proxy/pom.xml 2526503 
> 
> Diff: https://reviews.apache.org/r/8838/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Noa Resare
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message