incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pranav Saxena" <pranav.sax...@citrix.com>
Subject Re: Review Request: CloudStack-965: When a detailview action is prohibited, the operation dialog box should not show up in the mean time
Date Thu, 17 Jan 2013 10:15:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8992/#review15452
-----------------------------------------------------------


Your code changes look good . However , I have few concerns - 

1) The patch doesn't apply cleanly because of trailing whitespace errors . Hence could you
take care of these - 

home/pranav/Downloads/fix-cloudstack-965.patch:25: trailing whitespace.
        // Setup form validation			
/home/pranav/Downloads/fix-cloudstack-965.patch:27: trailing whitespace.
        $formContainer.find('input, select').each(function() {			  
/home/pranav/Downloads/fix-cloudstack-965.patch:31: space before tab in indent.
			  	else {
/home/pranav/Downloads/fix-cloudstack-965.patch:32: space before tab in indent.
			  	  $(this).rules('add', {});
/home/pranav/Downloads/fix-cloudstack-965.patch:33: space before tab in indent.
			  	}

2) Is there any specific reason for moving/reorganizing a section of code in dialog.js from
one point to other , though I know it won't affect anything. I believe , you could implement
the same without moving the chunks of code here and there , just to maintain the code consistency
and ordering. Please let me know if you have any concerns.

Thanks !


- Pranav Saxena


On Jan. 17, 2013, 8:09 a.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8992/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 8:09 a.m.)
> 
> 
> Review request for cloudstack and Pranav Saxena.
> 
> 
> Description
> -------
> 
> The patch is to resolve CLOUDSTACK-965 issue which prevents from showing the error message
and dialog form in the mean time.
> 
> 
> This addresses bug CLOUDSTACK-965.
> 
> 
> Diffs
> -----
> 
>   ui/scripts/ui/dialog.js 5236bb6 
> 
> Diff: https://reviews.apache.org/r/8992/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message