incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prachi Damle" <prachi.da...@citrix.com>
Subject Re: Review Request: [EC2 Query API] RevokeSecurityGroupIngress fails with 'EC2ResponseError'.
Date Thu, 17 Jan 2013 01:37:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8466/#review15437
-----------------------------------------------------------


Code looks good. How do we test the query API in master? Are there boto client tests added
to?

- Prachi Damle


On Dec. 12, 2012, 10:25 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8466/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 10:25 a.m.)
> 
> 
> Review request for cloudstack and Prachi Damle.
> 
> 
> Description
> -------
> 
> In AWSAPI while parsing the EC2 Query API request for RevokeSecurityGroupIngress, 
> 1. look for the right parameter values as per the AWS documentation.
> 2. provide support for multiple rules to be revoked simultaneously.
> 
> 
> This addresses bug CLOUDSTACK-607.
> 
> 
> Diffs
> -----
> 
>   awsapi/src/com/cloud/bridge/service/EC2RestServlet.java 4f74873 
> 
> Diff: https://reviews.apache.org/r/8466/diff/
> 
> 
> Testing
> -------
> 
> After setting up AWSAPI, using the boto client called
>  revoke_security_group(group_name=<sg_name>, ip_protocol=<protocol>, from_port=<from_port>,
to_port=<to_port>, cidr_ip=<cidr>)
> Successfully revoked the specified rule belonging to the security-group.
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message