incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: CLOUDSTACK-297 Reset SSH key to access VM (Similar to reset password)
Date Thu, 10 Jan 2013 02:39:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8905/#review15225
-----------------------------------------------------------


Holding on to this review until IP clearance issue is resolved, won't be shipped until PPMC
gives thumbs up.
Meanwhile, the patch can be fixed such that it applies cleanly and does not break anything
on master. Thanks.

- Rohit Yadav


On Jan. 9, 2013, 10:51 a.m., Harikrishna Patnala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8905/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 10:51 a.m.)
> 
> 
> Review request for cloudstack and Abhinandan Prateek.
> 
> 
> Description
> -------
> 
> A user VM can be associated with a SSH key pair while deploying that VM. A user can SSH
into the VM using the SSH private Key. 
> using this feature we can reset that SSH key pair corresponding to that VM, i.e., to
associate a new SSH key pair to the VM.
> 
> 
> This addresses bug CLOUDSTACK-297.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/api/commands/ResetSSHKeyCmd.java PRE-CREATION 
>   api/src/com/cloud/event/EventTypes.java e69e4a4 
>   api/src/com/cloud/network/element/UserDataServiceProvider.java 321ccc7 
>   api/src/com/cloud/vm/UserVmService.java 98d02db 
>   client/tomcatconf/commands.properties.in 1e70c0f 
>   server/src/com/cloud/network/NetworkManager.java ef0d4c5 
>   server/src/com/cloud/network/NetworkManagerImpl.java f7189df 
>   server/src/com/cloud/network/element/CloudZonesNetworkElement.java ae8be0d 
>   server/src/com/cloud/network/element/VirtualRouterElement.java 4ff1082 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 2980871 
>   server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java fcba6df

>   server/src/com/cloud/vm/UserVmManagerImpl.java 9356048 
>   server/test/com/cloud/network/MockNetworkManagerImpl.java 0b83f35 
>   server/test/com/cloud/vm/MockUserVmManagerImpl.java 35ee139 
>   server/test/com/cloud/vpc/MockNetworkManagerImpl.java 824e40d 
> 
> Diff: https://reviews.apache.org/r/8905/diff/
> 
> 
> Testing
> -------
> 
> I did the manual testing
> - Reset SSH keys for VM  already having SSH key
> - Reset SSH keys for VM  created from password enabled template and already having SSH
key 
> - Reset SSH keys for VM  having no SSH key
> - Reset SSH keys for VM  created from password enabled template and have no previous
SSH key
> - Reset SSH keys for VM  already having SSH key when VM is in running state
> - Reset SSH keys for VM  created from password enabled template and already having SSH
key  and VM is in running state
> 
> 
> Thanks,
> 
> Harikrishna Patnala
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message