incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: CLOUDSTACK-437 : User and Domain admin can create his API key and secret key
Date Thu, 03 Jan 2013 18:57:01 GMT


> On Jan. 3, 2013, 6:22 p.m., Rohit Yadav wrote:
> > Looks good, but why was it only limited to root admin, anyone wants to comment before
it can be applied on master?
> 
> Prasanna Santhanam wrote:
>     This was discussed sometime long ago and in multiple threads and making it a user
level action makes perfect sense.
>     
>     http://markmail.org/message/p65v3346tifovy2m

It does make sense, was just curious as to why the role mask to set to allow only root admin.


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8800/#review15031
-----------------------------------------------------------


On Jan. 2, 2013, 3:17 a.m., Isaac Chiang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8800/
> -----------------------------------------------------------
> 
> (Updated Jan. 2, 2013, 3:17 a.m.)
> 
> 
> Review request for cloudstack and Gavin Lee.
> 
> 
> Description
> -------
> 
> The patch is to fix the issue by using the same logic with issue : CLOUDSTACK-648. 
> 
> 
> Diffs
> -----
> 
>   client/tomcatconf/commands.properties.in e55017c 
>   ui/scripts/accounts.js ba741a4 
> 
> Diff: https://reviews.apache.org/r/8800/diff/
> 
> 
> Testing
> -------
> 
> 1. A CloudStack normal user can generate its own keys.
> 2. A Domain admin can generate keys for domain users, including subdomain admins and
subdomain users.
> 3. Under the same domain, a domain admin cannot generate key for another domain admin.
> 
> 
> Thanks,
> 
> Isaac Chiang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message