Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5B2EDD001 for ; Thu, 13 Dec 2012 05:43:31 +0000 (UTC) Received: (qmail 59582 invoked by uid 500); 13 Dec 2012 05:43:30 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 59548 invoked by uid 500); 13 Dec 2012 05:43:30 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 59534 invoked by uid 99); 13 Dec 2012 05:43:30 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2012 05:43:30 +0000 X-ASF-Spam-Status: No, hits=-1.6 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [74.125.149.83] (HELO na3sys009aog134.obsmtp.com) (74.125.149.83) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2012 05:43:23 +0000 Received: from mail-we0-f197.google.com ([74.125.82.197]) (using TLSv1) by na3sys009aob134.postini.com ([74.125.148.12]) with SMTP ID DSNKUMlq5ZNbpGUF9XBgPll8zGV1xVK4QG3i@postini.com; Wed, 12 Dec 2012 21:43:02 PST Received: by mail-we0-f197.google.com with SMTP id t11so1168206wey.0 for ; Wed, 12 Dec 2012 21:43:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=references:from:in-reply-to:mime-version:date:message-id:subject:to :content-type:x-gm-message-state; bh=kTB9CBE4TR+SkGs6rzu5BtmQS2dBwPZi6nq9Ev+4ufw=; b=VozREgFW7YxeO1zQETAxti8zWTj29Czv79fcJmZ9EUFJAib3jQwc/S0xymE6M6kI/Q CwK/sm7JHM0fDV9DZn3quoEAhglUWrsHNud4wsam7tL8CIcZdAGbtnvcgpOJP/KaMXcR HmHEXrHM6Yz5QuZ5p+0EaygFIwDynGG7YWiUqOt3PLtVsyJDA7E/t2S3//fBmUWjRKeq ldB5BRaVi6pntHV15PKa1io4KFLP3wWwqGD9XlANZoJsN2oZUSF3IZ4NRGDNJZ9JEksA Ffh4kZWRxVBWws0Y2FCqjY/8NfRtlQvbLsb93kPUDlJ7nCKCFKzxWt5mFQZ4wommnUZp t4Cg== Received: by 10.194.238.226 with SMTP id vn2mr5773399wjc.23.1355377380198; Wed, 12 Dec 2012 21:43:00 -0800 (PST) Received: by 10.194.238.226 with SMTP id vn2mr5773391wjc.23.1355377380027; Wed, 12 Dec 2012 21:43:00 -0800 (PST) References: <04D8F7AD-0DC4-4766-87E9-4BC96AE0D472@citrix.com> From: Chip Childers In-Reply-To: <04D8F7AD-0DC4-4766-87E9-4BC96AE0D472@citrix.com> Mime-Version: 1.0 (1.0) Date: Thu, 13 Dec 2012 00:42:50 -0500 Message-ID: <519595925327085130@unknownmsgid> Subject: Re: [DISCUSS] Api refactoring -- validation To: "" Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlhRBD6asmo7LiRRCp1EqMsg+GbtY1Cbm5ifCaSolt804es1XAGcoJou6hpnAQiLTUg2IPr1oMXfnjIQ5kkWFiS2QedAgYdIKSSjWFB21leVTnk5sAIK+5sGg3uDg5lBwVyxrAO3dwLzsSa/mL/jSayybVUeIuAzNJLRdNwo/FXbngF9NMKqHg/gy2lmGf6brS1+uHb X-Virus-Checked: Checked by ClamAV on apache.org Thanks Min! I think the comment about validating the DB entity was what confused me. Got it now. - chip Sent from my iPhone. On Dec 13, 2012, at 12:39 AM, Min Chen wrote: > I think that it is the latter case. > > -min > > Sent from my iPhone > > On Dec 12, 2012, at 9:32 PM, "Chip Childers" wrote: > >> On Wed, Dec 12, 2012 at 6:16 PM, Fang Wang wrote: >>> Hi all, >>> >>> In our current API refactoring work, we plan to add a validation annotation to >>> Validate DB entity, validate some parameter range, etc. >>> We plan to add the @validate annotation to API commands. >> >> This might be a silly question, but why the command classes and not >> the Dao's? Is this to validate the database inputs? Or are we >> talking about cleaning up the API input validation logic? >> >> Thanks! >> >>> IT is suggested we could use Hibernate Validator. Anyone with experience with >>> Hibernate validator, how we could deploy it here? >>> >>> 1. is there a version we should definitely use? >>> 2. Which option is better to integrate into our maven? Add it as dependency or as a plugin? >>> 3. What is the latest version working with maven? >>> >>> Thanks for any input, >>> -Fang >