Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 89FEEDB1E for ; Fri, 21 Dec 2012 00:04:52 +0000 (UTC) Received: (qmail 24890 invoked by uid 500); 21 Dec 2012 00:04:52 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 24839 invoked by uid 500); 21 Dec 2012 00:04:52 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 24823 invoked by uid 99); 21 Dec 2012 00:04:52 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 21 Dec 2012 00:04:52 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 204261C5C38; Fri, 21 Dec 2012 00:04:47 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6892313562116202267==" MIME-Version: 1.0 Subject: Re: Review Request: API Refactoring: annotate the remote access vpn related commands From: "Rohit Yadav" To: "Min Chen" , "Rohit Yadav" Cc: "cloudstack" , "Prasanna Santhanam" Date: Fri, 21 Dec 2012 00:04:47 -0000 Message-ID: <20121221000447.20143.28258@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8730/ X-Sender: "Rohit Yadav" References: <20121220235253.380.44901@reviews.apache.org> In-Reply-To: <20121220235253.380.44901@reviews.apache.org> Reply-To: "Rohit Yadav" --===============6892313562116202267== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8730/#review14788 ----------------------------------------------------------- Looks good, will do test them later. One thing though; get rid of any redun= dant imports like IdentityMapper imports as they are not used. We want to g= et rid of IdentityMapper. - Rohit Yadav On Dec. 20, 2012, 11:52 p.m., Prasanna Santhanam wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8730/ > ----------------------------------------------------------- > = > (Updated Dec. 20, 2012, 11:52 p.m.) > = > = > Review request for cloudstack, Rohit Yadav and Min Chen. > = > = > Description > ------- > = > API Refactoring: > = > 1. Annotated the remote access vpn commands > 2. Listzones command = > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/command/user/vpn/CreateRemoteAccessVp= nCmd.java 4d9e685 = > api/src/org/apache/cloudstack/api/command/user/vpn/DeleteRemoteAccessVp= nCmd.java 38a050a = > api/src/org/apache/cloudstack/api/command/user/vpn/ListRemoteAccessVpns= Cmd.java 210b864 = > api/src/org/apache/cloudstack/api/command/user/zone/ListZonesByCmd.java= 7bb6549 = > api/src/org/apache/cloudstack/api/response/IPAddressResponse.java d614e= 34 = > api/src/org/apache/cloudstack/api/response/RemoteAccessVpnResponse.java= c8caa43 = > = > Diff: https://reviews.apache.org/r/8730/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Prasanna Santhanam > = > --===============6892313562116202267==--