Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D8BD4D443 for ; Fri, 14 Dec 2012 19:53:09 +0000 (UTC) Received: (qmail 80337 invoked by uid 500); 14 Dec 2012 19:53:09 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 80261 invoked by uid 500); 14 Dec 2012 19:53:09 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 80251 invoked by uid 99); 14 Dec 2012 19:53:09 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2012 19:53:09 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 40DD11C5664; Fri, 14 Dec 2012 19:53:04 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0929751788785526875==" MIME-Version: 1.0 Subject: Re: Review Request: API refactoring -- Annotation for counter group. From: "Rohit Yadav" To: "Rohit Yadav" Cc: "cloudstack" , "Fang Wang" Date: Fri, 14 Dec 2012 19:53:04 -0000 Message-ID: <20121214195304.9609.96540@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8601/ X-Sender: "Rohit Yadav" References: <20121214193834.7729.5920@reviews.apache.org> In-Reply-To: <20121214193834.7729.5920@reviews.apache.org> Reply-To: "Rohit Yadav" --===============0929751788785526875== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8601/#review14514 ----------------------------------------------------------- Ship it! Applied on api_refactoring: commit 27482045ceef4ee4e8165c21f97c24200888beed Author: Fang Wang Date: Fri Dec 14 11:31:05 2012 -0800 API refactoring -- More parameter for counter group. - Rohit Yadav On Dec. 14, 2012, 7:38 p.m., Fang Wang wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8601/ > ----------------------------------------------------------- > = > (Updated Dec. 14, 2012, 7:38 p.m.) > = > = > Review request for cloudstack and Rohit Yadav. > = > = > Description > ------- > = > Add parameter annotation for counter group. = > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/command/admin/autoscale/DeleteCounter= Cmd.java 1e7f70a = > api/src/org/apache/cloudstack/api/response/CounterResponse.java 5260f1e = > = > Diff: https://reviews.apache.org/r/8601/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Fang Wang > = > --===============0929751788785526875==--