Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A892ED365 for ; Wed, 12 Dec 2012 01:38:16 +0000 (UTC) Received: (qmail 34926 invoked by uid 500); 12 Dec 2012 01:38:16 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 34889 invoked by uid 500); 12 Dec 2012 01:38:16 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 34879 invoked by uid 99); 12 Dec 2012 01:38:16 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2012 01:38:16 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id D28781C55A9; Wed, 12 Dec 2012 01:38:11 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4212034080886068583==" MIME-Version: 1.0 Subject: Re: Review Request: Move id field from BaseViewVO to individual VO classes to fix DAO layer search bug. From: "Rohit Yadav" To: "Rohit Yadav" Cc: "cloudstack" , "Min Chen" Date: Wed, 12 Dec 2012 01:38:11 -0000 Message-ID: <20121212013811.7729.81433@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8538/ X-Sender: "Rohit Yadav" References: <20121212011806.7729.16404@reviews.apache.org> In-Reply-To: <20121212011806.7729.16404@reviews.apache.org> Reply-To: "Rohit Yadav" --===============4212034080886068583== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8538/#review14344 ----------------------------------------------------------- Ship it! Applied in api_refactoring; commit 3661f7f99293838d18b53326b43cd486456ec60f Author: Min Chen Date: Tue Dec 11 17:14:14 2012 -0800 Fix several bugs of new refactored list apis. - Rohit Yadav On Dec. 12, 2012, 1:18 a.m., Min Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8538/ > ----------------------------------------------------------- > = > (Updated Dec. 12, 2012, 1:18 a.m.) > = > = > Review request for cloudstack and Rohit Yadav. > = > = > Description > ------- > = > Move id field from BaseViewVO to individual VO classes to fix DAO layer s= earch bug. > = > = > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > = > = > Diffs > ----- > = > api/src/org/apache/cloudstack/api/view/vo/BaseViewVO.java ca7cacb = > api/src/org/apache/cloudstack/api/view/vo/DomainRouterJoinVO.java d7d31= b0 = > api/src/org/apache/cloudstack/api/view/vo/EventJoinVO.java e8619d6 = > api/src/org/apache/cloudstack/api/view/vo/InstanceGroupJoinVO.java 0919= 487 = > api/src/org/apache/cloudstack/api/view/vo/ProjectAccountJoinVO.java 3f2= 53e8 = > api/src/org/apache/cloudstack/api/view/vo/ProjectJoinVO.java a3f28a1 = > api/src/org/apache/cloudstack/api/view/vo/ResourceTagJoinVO.java 052149= b = > api/src/org/apache/cloudstack/api/view/vo/SecurityGroupJoinVO.java 80ca= b11 = > api/src/org/apache/cloudstack/api/view/vo/UserAccountJoinVO.java 2cecd2= c = > api/src/org/apache/cloudstack/api/view/vo/UserVmJoinVO.java 0edf0be = > server/src/com/cloud/api/ApiDBUtils.java 4b889d6 = > = > Diff: https://reviews.apache.org/r/8538/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Min Chen > = > --===============4212034080886068583==--