Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0C9329DCC for ; Tue, 11 Dec 2012 23:53:49 +0000 (UTC) Received: (qmail 92569 invoked by uid 500); 11 Dec 2012 23:53:48 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 92541 invoked by uid 500); 11 Dec 2012 23:53:48 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 92531 invoked by uid 99); 11 Dec 2012 23:53:48 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2012 23:53:48 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 309CE1C555A; Tue, 11 Dec 2012 23:53:44 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============7249146156713831458==" MIME-Version: 1.0 Subject: Re: Review Request: Refactor ListProjectAccountCmd and ProjectAccountResponse. From: "Rohit Yadav" To: "Rohit Yadav" Cc: "cloudstack" , "Min Chen" Date: Tue, 11 Dec 2012 23:53:44 -0000 Message-ID: <20121211235344.7729.85673@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Rohit Yadav" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8537/ X-Sender: "Rohit Yadav" References: <20121211234450.7759.56170@reviews.apache.org> In-Reply-To: <20121211234450.7759.56170@reviews.apache.org> Reply-To: "Rohit Yadav" --===============7249146156713831458== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8537/#review14333 ----------------------------------------------------------- Ship it! Applied in api_refactoring: commit 9c93fee0dcde2927d9819cf82b86237b632f35d0 Author: Min Chen Date: Tue Dec 11 15:42:52 2012 -0800 Refactor ListProjectAccountCmd and ProjectAccountResponse. - Rohit Yadav On Dec. 11, 2012, 11:44 p.m., Min Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8537/ > ----------------------------------------------------------- > = > (Updated Dec. 11, 2012, 11:44 p.m.) > = > = > Review request for cloudstack and Rohit Yadav. > = > = > Description > ------- > = > Refactor ListProjectAccountCmd and ProjectAccountResponse, and create DB = view for ProjectAccount. > = > = > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > = > = > Diffs > ----- > = > api/src/com/cloud/projects/ProjectService.java 2ef367b = > api/src/org/apache/cloudstack/api/ResponseGenerator.java 383ecf8 = > api/src/org/apache/cloudstack/api/command/user/account/ListProjectAccou= ntsCmd.java b0cdcd9 = > api/src/org/apache/cloudstack/api/response/ProjectAccountResponse.java = c20c023 = > api/src/org/apache/cloudstack/api/view/vo/ProjectAccountJoinVO.java PRE= -CREATION = > server/src/com/cloud/api/ApiDBUtils.java a60f91b = > server/src/com/cloud/api/ApiResponseHelper.java 76fe58d = > server/src/com/cloud/configuration/DefaultComponentLibrary.java af7a84d = > server/src/com/cloud/projects/ProjectManagerImpl.java d9ff0b3 = > server/src/com/cloud/projects/dao/ProjectAccountJoinDao.java PRE-CREATI= ON = > server/src/com/cloud/projects/dao/ProjectAccountJoinDaoImpl.java PRE-CR= EATION = > server/src/com/cloud/user/dao/UserAccountJoinDao.java 05858d0 = > server/src/com/cloud/user/dao/UserAccountJoinDaoImpl.java 8ffff0f = > server/test/com/cloud/projects/MockProjectManagerImpl.java dad777a = > setup/db/create-schema.sql 6699d76 = > = > Diff: https://reviews.apache.org/r/8537/diff/ > = > = > Testing > ------- > = > = > Thanks, > = > Min Chen > = > --===============7249146156713831458==--