Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 783C7D99C for ; Tue, 11 Dec 2012 01:43:17 +0000 (UTC) Received: (qmail 81534 invoked by uid 500); 11 Dec 2012 01:43:17 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 81492 invoked by uid 500); 11 Dec 2012 01:43:17 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 81478 invoked by uid 99); 11 Dec 2012 01:43:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Dec 2012 01:43:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id A10B51C54C6; Tue, 11 Dec 2012 01:43:12 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============4720767537782115764==" MIME-Version: 1.0 Subject: Review Request: Refactor ListUsersCmd and UserResponse. From: "Min Chen" To: "Rohit Yadav" Cc: "cloudstack" , "Min Chen" Date: Tue, 11 Dec 2012 01:43:12 -0000 Message-ID: <20121211014312.7729.22860@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Min Chen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8454/ X-Sender: "Min Chen" Reply-To: "Min Chen" --===============4720767537782115764== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8454/ ----------------------------------------------------------- Review request for cloudstack and Rohit Yadav. Description ------- Refactor ListUsersCmd and UserResponse, and create UserAccount db view. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. Diffs ----- api/src/com/cloud/user/AccountService.java e9558fc = api/src/org/apache/cloudstack/api/ResponseGenerator.java 2ccbec5 = api/src/org/apache/cloudstack/api/command/admin/user/ListUsersCmd.java c7= f0cbb = api/src/org/apache/cloudstack/api/response/UserResponse.java 2868be4 = api/src/org/apache/cloudstack/api/view/vo/UserAccountJoinVO.java PRE-CREA= TION = server/src/com/cloud/api/ApiDBUtils.java f3ee0ed = server/src/com/cloud/api/ApiResponseHelper.java 04a9314 = server/src/com/cloud/configuration/DefaultComponentLibrary.java 5dc1c80 = server/src/com/cloud/user/AccountManagerImpl.java c0cbe47 = server/src/com/cloud/user/dao/UserAccountJoinDao.java PRE-CREATION = server/src/com/cloud/user/dao/UserAccountJoinDaoImpl.java PRE-CREATION = server/test/com/cloud/user/MockAccountManagerImpl.java 90422c7 = setup/db/create-schema.sql 406145c = Diff: https://reviews.apache.org/r/8454/diff/ Testing ------- Thanks, Min Chen --===============4720767537782115764==--