incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Cahill <dcah...@midokura.jp>
Subject SystemVM keypair setting in developer mode
Date Thu, 20 Dec 2012 05:34:01 GMT
Hi,

There seem to be crossed wires about systemVM keypairs and whether the
management server can be run as a user other than "cloud".

On Nov 1st, in the mailing list thread "Setting the ssh.publickey and
ssh.privatekey options", we decided that if a user is in developer mode
(used mvn -P developer -pl developer -Ddeploydb), the "developer" key
should be inserted into the database, allowing systemvm keypairs to be set
even if the user is not "cloud". This was reviewed (
https://reviews.apache.org/r/7861/) and committed (
https://github.com/apache/incubator-cloudstack/commit/476e771c1c8f81b87a77883922bc1b35dea213fc
).

However, a Dec 1st commit changes the condition from:
Disallow setting systemvm keypairs if the user is not "cloud" user AND is
not in developer mode
to
Disallow setting systemvm keypairs if the user is not "cloud" user OR is
not in developer mode

This effectively means the management server can't be run as a non-cloud
user.

I can't tell form the commit message if this effect is intentional:
"Removed that darn exceptions when cloudstack is running in windows. It's a
simple or check that was written as an and check"
https://github.com/apache/incubator-cloudstack/commit/6036f73725889b3557263e1a4a80106f11217974

Anyone have any insights?

Thanks,
Dave.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message