incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Nalley <da...@gnsa.us>
Subject Re: Review Request: Added Unit test cases for com.cloud.api.commands
Date Wed, 19 Dec 2012 16:36:06 GMT
On Tue, Dec 18, 2012 at 10:59 PM, Rohit Yadav <rohit.yadav@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8545/#review14711
> -----------------------------------------------------------
>
>
> Thanks for your patch, but your changes are not applying cleanly and will break both
api_refactoring and javelin.  I will have to merge the api_refactoring branch soon else there
will be pile of review with a lot of merge conflicts.
>
> My target was to merge api_refactoring yesterday but I thought I would fix some more
stuff before I merge it on master so it won't break anything on master.
> If you already working on some other unit tests pl. work on the api_refactoring branch,
I'm planning to send a merge request and progress report on dev ML this weekend.
>
> - Rohit Yadav
>

Please discuss this on list before you attempt a merge. Something of
this magnitude should not happen without some degree of notice.

--David

Mime
View raw message