incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chip Childers <chip.child...@sungard.com>
Subject API Guru's help needed looking at two reviews
Date Tue, 18 Dec 2012 04:23:19 GMT
Hi all,

I was looking at two of Meghna's patch submissions (
https://reviews.apache.org/r/8355/  and
https://reviews.apache.org/r/8545 ) and realized that I'd like to have
an API guru take a look at the proposed modifications.

Review 8355 as 2 patches, one setup as the actual patch for review and
the followup fixes are included in an attachment.  You have to apply
both to see the expected result.

I've applied the patches and tested the compile + new unit tests, but
I'd like someone else to review the patches as well.  They effect
several command class files, modifying them to better support test
mock objects.  I don't want to push this commit without another pair
of eyes.

Thanks!

-chip

Mime
View raw message