incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Fang Wang <fang.w...@citrix.com>
Subject RE: Review Request: API_refactoring: add parameter annotation for user 'security-group' group
Date Thu, 13 Dec 2012 22:38:38 GMT
I changed the mapping in the response class back to @Entity. So your code is fine now.

Thanks,
-Fang


From: Likitha Shetty [mailto:noreply@reviews.apache.org] On Behalf Of Likitha Shetty
Sent: Wednesday, December 12, 2012 9:40 PM
To: Rohit Yadav; Fang Wang
Cc: cloudstack; Likitha Shetty
Subject: Review Request: API_refactoring: add parameter annotation for user 'security-group'
group

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8565/


Review request for cloudstack, Rohit Yadav and Fang Wang.
By Likitha Shetty.
Description

Add the entityType to the parameter annotation.

Annotate SecurityGroupRules response

Bugs: CLOUDSTACK-518
Diffs

 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupEgressCmd.java
(566e5c0)
 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupIngressCmd.java
(b5e6aa2)
 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/CreateSecurityGroupCmd.java
(b83a972)
 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/DeleteSecurityGroupCmd.java
(5ca76ef)
 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/ListSecurityGroupsCmd.java
(0149a0a)
 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupEgressCmd.java
(9783218)
 *   api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupIngressCmd.java
(34c0004)
 *   api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java (206e5fb)

View Diff<https://reviews.apache.org/r/8565/diff/>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message