incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kishan Kavala <Kishan.Kav...@citrix.com>
Subject RE: Database/code version mismatch
Date Fri, 21 Dec 2012 10:00:41 GMT
Updated DB version during DB deploy
        1. Modified create-schema.sql to add version as 4.1.0 instead of 4.0.0
        2. Removed schema-40to41.sql and moved the content to schema-40to410.sql
        3. Added to schema-40to410.sql Upgrade40to41.java

commit 8acc85ca5371d8fb3c66ac4083633849422f5654

~kishan

-----Original Message-----
From: Mills, Joseph [mailto:joe@midokura.jp] 
Sent: Friday, 21 December 2012 1:09 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Database/code version mismatch

thanks for the reply, Kishan.

On Fri, Dec 21, 2012 at 4:17 PM, Kishan Kavala <Kishan.Kavala@citrix.com>wrote:

> Joe,
>  You are right. Version has to change in create-schema.sql. Also, 
> schema-40to41.sql has to be added  "getPrepareScripts"  in 
> Upgrade40to41.java Upgrade should not run everytime we do deploy 
> database.
>
> I'll make the required changes.
>
> ~kishan
>
> -----Original Message-----
> From: Mills, Joseph [mailto:joe@midokura.jp]
> Sent: Friday, 21 December 2012 11:58 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Database/code version mismatch
>
> There is a database/code version mismatch that currently exists in the 
> master branch, and I was hoping someone might be able to provide some 
> insights.
>
> The Database version is set to "4.0.0.2012-09-12T14:47:37Z" (in 
> create-schema.sql).
>
> However in the top level pom.xml, the code version is set to 
> "4.1.0-SNAPSHOT".
>
> Is there any reason we are keeping these different?
>
> This causes an upgrade every time we deploy the database, which is not 
> necessarily a problem. However, in this commit:
>
>
> https://github.com/apache/incubator-cloudstack/commit/432ea9c7d4aff3f7
> e682f2951f49ed3e95778d9f
>
>
> I see the same entry being added to both create-schema.sql and 
> schema-40to41.sql.
>
> This seems like it would be a problem if schema-40to41.sql were ever 
> executed by Upgrade40to41.java, but right now it is not added to the 
> "getPrepareScripts" call. It seems like this should be executed now 
> that schema-40to41.sql has contents.
>
> Can anyone provide some clarification on this?
>
> Thanks,
> Joe
>

Mime
View raw message