incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: [API] ListTemplates API is not returning "Enable SSH Key" attribute for any given template
Date Mon, 24 Dec 2012 03:08:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8546/#review14879
-----------------------------------------------------------


Looks good, not sure why it was not included in the response, security consideration?

- Rohit Yadav


On Dec. 12, 2012, 12:03 p.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8546/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2012, 12:03 p.m.)
> 
> 
> Review request for cloudstack and Alena Prokharchyk.
> 
> 
> Description
> -------
> 
> Update the TemplateResponse by adding 'sshkeyenabled' attribute to it. This attribute
is set to the value that the user passes as input for parameter 'sshkeyenabled' while registering
the template.
> 
> 
> This addresses bug CLOUDSTACK-614.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/api/response/TemplateResponse.java 5c3d339 
>   server/src/com/cloud/api/ApiResponseHelper.java ebe8415 
> 
> Diff: https://reviews.apache.org/r/8546/diff/
> 
> 
> Testing
> -------
> 
> Called API command=listTemplates&listall=true&templatefilter=featured
> The JSON response contained a boolean SSH related attribute called 'sshkeyenabled' which
mentioned if the template is SSH enabled or not.
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message