incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: createSetupGuestNetworkCommand in VpcVirtualNetworkApplianceManagerImpl.java fails when the broadcast URI is not a long
Date Mon, 24 Dec 2012 02:52:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8701/
-----------------------------------------------------------

(Updated Dec. 24, 2012, 2:52 a.m.)


Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal.


Changes
-------

Pl. fix your editor. Patch fails as per coding conventions. No tabs, only spaces. Added Hugo
and Chiradeep as reviewers.


Description
-------

This method expects the broadcast uri to be a long (which is the case for vlan isolation),
but fails when another value is passed into it like the lswitch-guid for Nicira NVP networks.


Diffs
-----

  server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerImpl.java 1fd710d 

Diff: https://reviews.apache.org/r/8701/diff/


Testing
-------

mvn clean test


Thanks,

Roeland Kuipers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message