incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <bhais...@apache.org>
Subject Re: Review Request: Add annotation for systemVM commands.
Date Thu, 20 Dec 2012 09:41:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8693/#review14752
-----------------------------------------------------------


Patch did not apply cleanly. Pl. fix your editor, no tabs only whitespace and no trailing
whitespaces.
The patch was partially applied as HostResponse was already annotated and SystemVmResponse
was not. Pl. git pull latest api_refactoring and send patches through that. Always git pull
--rebase origin api_refactoring to get the latest changes. Pl. build, test and when submitting
patches and mention if you've tested or if you've not tested.
Lastly, before working or annotating any set of APIs, just send an email so that we won't
have more than one person annotating the same set of apis. Thanks.

commit ef49485aba6607ddb617580f503ca7c9a7577b7f
Author: Rohit Yadav <bhaisaab@apache.org>
Date:   Thu Dec 20 01:36:53 2012 -0800

    api: Annotate missing systemvm api, annotate SystemVmResponse
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>

commit b1602a36297410a54f306ca46164469bea9d7354
Author: Fang Wang <fang.wang@citrix.com>
Date:   Thu Dec 20 01:36:10 2012 -0800

    api: Annotate some systemvm commands
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>

- Rohit Yadav


On Dec. 20, 2012, 1:25 a.m., Fang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8693/
> -----------------------------------------------------------
> 
> (Updated Dec. 20, 2012, 1:25 a.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> Add annotation for systemVM commands
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-518.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/admin/systemvm/DestroySystemVmCmd.java 816cbe4

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/ListSystemVMsCmd.java 279e1a4

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/MigrateSystemVMCmd.java 1d20496

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/RebootSystemVmCmd.java 9701598

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/StartSystemVMCmd.java 9414c64

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/StopSystemVmCmd.java 654ba4f

>   api/src/org/apache/cloudstack/api/command/admin/systemvm/UpgradeSystemVMCmd.java 3383c56

>   api/src/org/apache/cloudstack/api/response/HostResponse.java 8b4cd3e 
>   api/src/org/apache/cloudstack/api/response/StoragePoolResponse.java 64174eb 
> 
> Diff: https://reviews.apache.org/r/8693/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fang Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message