incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-649: KVM storage gc does not delete the invalid snapshots from physical storage
Date Tue, 18 Dec 2012 00:09:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8632/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 12:09 a.m.)


Review request for cloudstack, Nitin Mehta, edison su, and Marcus Sorensen.


Changes
-------

handling upgraded KVM setups from v2.2 -> v3.0


Description
-------

When CleanupSnapshotBackupCommand is sent to the SSVM agent because it needs to perform storage
GC - outdated snapshots remain undeleted. But the answer returned to mgmt server is success.
This is related to CLOUDSTACK-643 where KVM uses a different path to its snapshot backups
that includes the zoneid in the path.


KVM uses /snapshots/zoneid/accountid/volumeid for its snapshot path.  The
    cleanupbackupsnapshotcommand which performs GC interprets an invalid path (as
    /snapshots/accountid/volumeid) to the snapshot and fails to delete them from
    sec.  storage.
    
    Now GC path is corrected so snapshots removed fmor DB are also removed from
    secondary storage.


This addresses bug CLOUDSTACK-649.


Diffs (updated)
-----

  core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java d8fdc3a 

Diff: https://reviews.apache.org/r/8632/diff/


Testing
-------

1. Tested create snapshot, delete snapshot
2. Tested recurring snapshot creation , deletion via storage gc

Both scenarios pass


Thanks,

Prasanna Santhanam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message