incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: CLOUDSTACK-643: KVM snapshots deleted via API not deleted from physical secondary storage
Date Tue, 18 Dec 2012 00:06:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8613/
-----------------------------------------------------------

(Updated Dec. 18, 2012, 12:06 a.m.)


Review request for cloudstack, edison su and Marcus Sorensen.


Changes
-------

Handling upgraded KVM setups from 2.2 to 3.0


Description
-------

KVM snapshot command objects return absolute path to their qcow2
backups while the SSVM responsible for the snapshot deletion builds a
path from the tenant's associated path. This causes a quiet failure
resulting in a successful answer back to management server while the
image still persists on sec. storage.

Cmd object sent by management server:

{
    Cmd,
    MgmtId: 345050870294,
    via: 11,
    Ver: v1,
    Flags: 100011,
    [
        {
            "DeleteSnapshotBackupCommand": {
                "all": false,
                "snapshotUuid": "/snapshots/3/7/31/any_ROOT-29_20121214210220",
                "secondaryStorageUrl": "nfs://secstorage/export/home/storage/secondary",
                "dcId": 3,
                "accountId": 7,
                "volumeId": 31,
                "wait": 0
            }
        }
    ]
}

Path interpreted by CS:
secondaryStorageUrl + dcId + accountId + volumeId + snapshotUuid
= nfs://secstorage/export/home/storage/secondary/3/7/31/snapshots/3/7/31/any_ROOT-29_20121214210220

While it should be
= nfs://secstorage/export/home/storage/secondary/snapshots/3/7/31/any_ROOT-29_20121214210220


This addresses bug cloudstack-643.


Diffs (updated)
-----

  core/pom.xml 3d6356e 
  core/src/com/cloud/storage/resource/NfsSecondaryStorageResource.java d8fdc3a 

Diff: https://reviews.apache.org/r/8613/diff/


Testing
-------


Thanks,

Prasanna Santhanam


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message