incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: API_refactoring: add parameter annotation for user 'security-group' group
Date Sat, 15 Dec 2012 20:59:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8565/#review14546
-----------------------------------------------------------


Does not apply cleanly. The type has to be changed. Will fix this later today.

- Rohit Yadav


On Dec. 13, 2012, 5:40 a.m., Likitha Shetty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8565/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2012, 5:40 a.m.)
> 
> 
> Review request for cloudstack, Rohit Yadav and Fang Wang.
> 
> 
> Description
> -------
> 
> Add the entityType to the parameter annotation.
> Annotate SecurityGroupRules response
> 
> 
> This addresses bug CLOUDSTACK-518.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupEgressCmd.java
566e5c0 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/AuthorizeSecurityGroupIngressCmd.java
b5e6aa2 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/CreateSecurityGroupCmd.java
b83a972 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/DeleteSecurityGroupCmd.java
5ca76ef 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/ListSecurityGroupsCmd.java
0149a0a 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupEgressCmd.java
9783218 
>   api/src/org/apache/cloudstack/api/command/user/securitygroup/RevokeSecurityGroupIngressCmd.java
34c0004 
>   api/src/org/apache/cloudstack/api/response/SecurityGroupRuleResponse.java 206e5fb 
> 
> Diff: https://reviews.apache.org/r/8565/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Likitha Shetty
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message