incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Brockmeier" <...@zonker.net>
Subject Re: Review Request: Documentation for the new features: Optional Public IP assignment for EIP with Basic Zone and User-provided hostname in vCenter
Date Fri, 14 Dec 2012 19:48:26 GMT


> On Dec. 13, 2012, 3:17 p.m., Joe Brockmeier wrote:
> > The patch applies cleanly, but it does not build. I stopped at two errors. There's
a syntax error in en-US/creating-network-offerings.xml at line 21 - there are two comment
closures (-->) so you need to remove one. 
> > 
> > It also fails at creating-network-offerings.xml:201: validity error : IDREF attribute
linkend references an unknown ID "firewall-rules"
> > 
> > You might want to pull master to be sure it's up to date, create a fresh branch
and then test there to ensure that this builds with Publican. 
> > 
> > Thanks!
> 
> Radhika PC wrote:
>     A new patch is attached.

Hi Radhika, 

Have you tested building all guides? I can build the install guide without error, but I get
this when building the admin guide:

creating-network-offerings.xml:6: validity error : ID creating-network-offerings already defined
creating-network-offerings.xml:204: validity error : IDREF attribute linkend references an
unknown ID "firewall-rules"
creating-network-offerings.xml:204: validity error : IDREF attribute linkend references an
unknown ID "firewall-rules"


- Joe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8180/#review14438
-----------------------------------------------------------


On Dec. 14, 2012, 9:12 a.m., Radhika PC wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8180/
> -----------------------------------------------------------
> 
> (Updated Dec. 14, 2012, 9:12 a.m.)
> 
> 
> Review request for cloudstack, Chip Childers, Venkata Siva Vijayendra Bhamidipati, Jessica
Tomechak, Murali Reddy, and Joe Brockmeier.
> 
> 
> Description
> -------
> 
> This review request is for the documentation written for the following features:
> 
> Optional Public IP assignment for EIP with Basic Zone
> User-provided host name in vCenter 
> 
> 
> Diffs
> -----
> 
>   docs/en-US/Installation_Guide.xml 2f60aca 
>   docs/en-US/about-working-with-vms.xml 47153e2 
>   docs/en-US/append-displayname-vms.xml PRE-CREATION 
>   docs/en-US/creating-network-offerings.xml ab56920 
>   docs/en-US/elastic-ip.xml PRE-CREATION 
>   docs/en-US/networks.xml a7b9ea1 
>   docs/en-US/prepare-system-vm-template.xml 22674d4 
>   docs/en-US/set-up-network-for-users.xml 2b40923 
>   docs/en-US/using-multiple-guest-networks.xml 9076a81 
>   docs/en-US/virtual-machines.xml 7c74932 
> 
> Diff: https://reviews.apache.org/r/8180/diff/
> 
> 
> Testing
> -------
> 
> Patch cleanly applies. doc is reviewed by QA
> 
> 
> Thanks,
> 
> Radhika PC
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message