incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: The already deleted same hostname is not deleted from /etc/hosts of vRouter.
Date Fri, 14 Dec 2012 07:03:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8289/#review14493
-----------------------------------------------------------

Ship it!


looks good. applied to master branch.

Thanks for the patch. Please close the review as submitted

commit 15704cfa6cb26737342cb6293194da129147b976
Author: Atsushi Midorikawa <midorika@stratosphere.co.jp>
Date:   Thu Dec 13 22:59:35 2012 -0800

    virtual router: edithosts.sh cleanup fails on existing hosts
    
    The already deleted same hostname  is not deleted from /etc/hosts of
    vRouter.
    
    vRouter's /etc/hosts format:
    $ip $host
    
    This patch fixes deletion logic below.
    sed -i /"$host "/d $HOSTS
    
    Signed-off-by: Prasanna Santhanam <tsp@apache.org>


- Prasanna Santhanam


On Nov. 30, 2012, 5:45 a.m., Atsushi Midorikawa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8289/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2012, 5:45 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> The already deleted same hostname  is not deleted from /etc/hosts of vRouter. 
> 
> vRouter's /etc/hosts format:
> $ip $host
> 
> This deletion logic does not match. 
> sed -i /"$host "/d $HOSTS
> 
> 
> Diffs
> -----
> 
>   patches/systemvm/debian/config/root/edithosts.sh 3c6102d 
> 
> Diff: https://reviews.apache.org/r/8289/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Atsushi Midorikawa
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message