incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Likitha Shetty" <likitha.she...@citrix.com>
Subject Re: Review Request: [EC2 Query API] Provide DescribeKeyPairs Query API support in CS AWSAPI.
Date Tue, 11 Dec 2012 11:36:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8465/
-----------------------------------------------------------

(Updated Dec. 11, 2012, 11:36 a.m.)


Review request for cloudstack and Prachi Damle.


Summary (updated)
-----------------

[EC2 Query API] Provide DescribeKeyPairs Query API support in CS AWSAPI.


Description
-------

As a part of EC2 Query API support, resolve the NPE obtained when DescribeKeyPairs is called
In EC2Engine modify DescribeKeyPairs implementation to be consistent with the other Describe*
API implementation


This addresses bug CLOUDSTACK-197.


Diffs
-----

  awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java eb25249 
  awsapi/src/com/cloud/bridge/service/core/ec2/EC2KeyPairFilterSet.java 021487c 

Diff: https://reviews.apache.org/r/8465/diff/


Testing
-------

After setting up AWSAPI, using the boto client called
1. get_all_key_pairs()
2. get_all_key_pairs(keynames='<cs_key_name>')
Both successfully returned the existing key-pairs.


Thanks,

Likitha Shetty


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message