incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: Clean up some view VO code to remove code duplication.
Date Mon, 10 Dec 2012 19:35:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8444/#review14256
-----------------------------------------------------------

Ship it!


Applied on api_refactoring
commit 9a3632d807ee899a08938b4b343a52514e21181f
Author: Min Chen <min.chen@citrix.com>
Date:   Mon Dec 10 11:21:01 2012 -0800

    Create Base view VO object to remove some code duplication.

- Rohit Yadav


On Dec. 10, 2012, 7:26 p.m., Min Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8444/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2012, 7:26 p.m.)
> 
> 
> Review request for cloudstack and Rohit Yadav.
> 
> 
> Description
> -------
> 
> Create Base Db view VO class to have some common view VO code.
> 
> 
> This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527.
> 
> 
> Diffs
> -----
> 
>   api/src/org/apache/cloudstack/api/view/vo/BaseViewVO.java PRE-CREATION 
>   api/src/org/apache/cloudstack/api/view/vo/DomainRouterJoinVO.java 747cde5 
>   api/src/org/apache/cloudstack/api/view/vo/EventJoinVO.java da322fb 
>   api/src/org/apache/cloudstack/api/view/vo/ResourceTagJoinVO.java e39c115 
>   api/src/org/apache/cloudstack/api/view/vo/SecurityGroupJoinVO.java 725ee90 
>   api/src/org/apache/cloudstack/api/view/vo/UserVmJoinVO.java aff2a1b 
> 
> Diff: https://reviews.apache.org/r/8444/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Min Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message