incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abhinandan Prateek" <aprat...@apache.org>
Subject Re: Review Request: CLOUDSTACK-596 : DeployVM command takes a lot of time to return job id
Date Mon, 10 Dec 2012 09:28:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8441/#review14237
-----------------------------------------------------------

Ship it!


Ship It!

- Abhinandan Prateek


On Dec. 10, 2012, 8:42 a.m., Koushik Das wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8441/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2012, 8:42 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
> 
> 
> Description
> -------
> 
> Issue happens while deploying VM in advanced zone and 'networkids' parameter is not passed
to deployVM command. In this case CS tries to identify a default guest network to be used
for deploying VM. This logic is not optimized and latency increases with increase in user
accounts and guest networks. Optimized logic for getting default network.
> 
> 
> This addresses bug CLOUDSTACK-596.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/network/NetworkManagerImpl.java b3fdf32 
>   server/src/com/cloud/network/dao/NetworkDao.java a2e37b7 
>   server/src/com/cloud/network/dao/NetworkDaoImpl.java cbfec89 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 837e3f7 
>   server/test/com/cloud/vpc/dao/MockNetworkDaoImpl.java 2a675b3 
> 
> Diff: https://reviews.apache.org/r/8441/diff/
> 
> 
> Testing
> -------
> 
> Citrix QA verified it on a simulated environment (verified using a Citrix private build).
> Time taken for deployVM to return async. job id after fix is < 1s - tested with over
4K accounts and 9500 VMs in simulator setup. Earlier it used to take 14-15s for the same.
> 
> 
> Thanks,
> 
> Koushik Das
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message