incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohit Yadav" <rohit.ya...@citrix.com>
Subject Re: Review Request: Changed the @Parameter for some VM group commands.
Date Wed, 05 Dec 2012 19:53:53 GMT


> On Dec. 5, 2012, 7:53 p.m., Rohit Yadav wrote:
> > Ship It!

Committed on api_refactoring branch:

commit ee0a4a41d0f8db2f895a1699150c60cac6facab8
Author: Fang Wang <fang.wang@citrix.com>
Date:   Wed Dec 5 11:50:23 2012 -0800

    api_refactor: entity annotation and fix parameter
    
    - Add Entity annotation
    - Annotate few responses
    - Fix Parameter annotation to have entityType
    
    Signed-off-by: Rohit Yadav <bhaisaab@apache.org>


- Rohit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8133/#review14057
-----------------------------------------------------------


On Nov. 20, 2012, 2:05 a.m., Fang Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8133/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2012, 2:05 a.m.)
> 
> 
> Review request for cloudstack, Prachi Damle and Alex Huang.
> 
> 
> Description
> -------
> 
> Part of the API refactoring work. This is the initial modification to the @Parameter
annotation for
> some commands in the VM group. 
> 
> 
> This addresses bug cloudstack-518.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/api/Parameter.java 2da3c40 
>   api/src/org/apache/cloudstack/user/api/vm/commands/AssignVMCmd.java PRE-CREATION 
>   api/src/org/apache/cloudstack/user/api/vm/commands/CreateVMGroupCmd.java PRE-CREATION

>   api/src/org/apache/cloudstack/user/api/vm/commands/DeleteVMGroupCmd.java PRE-CREATION

>   api/src/org/apache/cloudstack/user/api/vm/commands/DeployVMCmd.java PRE-CREATION 
>   api/src/org/apache/cloudstack/user/api/vm/commands/DestroySystemVmCmd.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/8133/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Fang Wang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message