Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E54A3EC38 for ; Thu, 22 Nov 2012 00:24:34 +0000 (UTC) Received: (qmail 78426 invoked by uid 500); 22 Nov 2012 00:24:34 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 78385 invoked by uid 500); 22 Nov 2012 00:24:34 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 78374 invoked by uid 99); 22 Nov 2012 00:24:34 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 22 Nov 2012 00:24:34 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id F0B2B1C4B9B; Thu, 22 Nov 2012 00:24:30 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0984530796624313018==" MIME-Version: 1.0 Subject: Re: Review Request: List API performance optimization part I. From: "Min Chen" To: "Prachi Damle" Cc: "cloudstack" , "Min Chen" , "Chiradeep Vittal" Date: Thu, 22 Nov 2012 00:24:30 -0000 Message-ID: <20121122002430.3328.85198@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "Min Chen" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/8172/ X-Sender: "Min Chen" References: <20121122000542.16572.68531@reviews.apache.org> In-Reply-To: <20121122000542.16572.68531@reviews.apache.org> Reply-To: "Min Chen" --===============0984530796624313018== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable > On Nov. 22, 2012, 12:05 a.m., Chiradeep Vittal wrote: > > utils/src/com/cloud/utils/db/GenericDaoBase.java, line 1811 > > > > > > this change seems unrelated? perhaps it needs a new bug? SQL statement used here to get total count for list API (select count(*) ..= ..) will not work if there is group by clause. > On Nov. 22, 2012, 12:05 a.m., Chiradeep Vittal wrote: > > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3006 > > > > > > this is a major piece of surgery on this method. How are you sure t= hat the before and after results are identical? I have done a prototype before this checkin and verified that it returns th= e same result as before. UserVmJoinVO is view object containing all the fie= lds before in UserVm interface, no information is lost. > On Nov. 22, 2012, 12:05 a.m., Chiradeep Vittal wrote: > > api/src/com/cloud/api/view/vo/IControlledViewEntity.java, line 27 > > > > > > It isn't the current practice to prefix interfaces with "I". I can change that to ControlledViewEntity. - Min ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8172/#review13683 ----------------------------------------------------------- On Nov. 21, 2012, 6:54 p.m., Min Chen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8172/ > ----------------------------------------------------------- > = > (Updated Nov. 21, 2012, 6:54 p.m.) > = > = > Review request for cloudstack and Prachi Damle. > = > = > Description > ------- > = > This is part 1 of list API refactoring. > Commands covered: listVmsCmd, listRoutersCmd > Response covered: UserVmResponse, DomainRouterResponse. > DB views created: user_vm_view, domain_router_view. > = > = > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-527. > = > = > Diffs > ----- > = > api/src/com/cloud/api/ResponseGenerator.java 996a5fc = > api/src/com/cloud/api/ResponseObject.java 2d08fb9 = > api/src/com/cloud/api/commands/ListRoutersCmd.java 8bf9ba8 = > api/src/com/cloud/api/commands/ListVMsCmd.java 2f6f988 = > api/src/com/cloud/api/response/BaseResponse.java e343a10 = > api/src/com/cloud/api/response/DomainRouterResponse.java d710aad = > api/src/com/cloud/api/response/IControlledViewEntityResponse.java PRE-C= REATION = > api/src/com/cloud/api/response/NicResponse.java 69d5c31 = > api/src/com/cloud/api/response/UserVmResponse.java f74c072 = > api/src/com/cloud/api/view/vo/DomainRouterJoinVO.java PRE-CREATION = > api/src/com/cloud/api/view/vo/IControlledViewEntity.java PRE-CREATION = > api/src/com/cloud/api/view/vo/UserVmJoinVO.java PRE-CREATION = > api/src/com/cloud/server/ManagementService.java 7532cae = > api/src/com/cloud/vm/UserVmService.java 02682b0 = > server/src/com/cloud/api/ApiDBUtils.java 418fe362 = > server/src/com/cloud/api/ApiResponseHelper.java caabd71 = > server/src/com/cloud/api/ApiServer.java a5c9ea5 = > server/src/com/cloud/api/response/ApiResponseSerializer.java dc15763 = > server/src/com/cloud/configuration/DefaultComponentLibrary.java 4edd402 = > server/src/com/cloud/server/ManagementServerImpl.java 117be57 = > server/src/com/cloud/user/AccountManager.java 90a34ad = > server/src/com/cloud/user/AccountManagerImpl.java 0def008 = > server/src/com/cloud/vm/UserVmManager.java 4ce9bfe = > server/src/com/cloud/vm/UserVmManagerImpl.java a2a548f = > server/src/com/cloud/vm/dao/DomainRouterJoinDao.java PRE-CREATION = > server/src/com/cloud/vm/dao/DomainRouterJoinDaoImpl.java PRE-CREATION = > server/src/com/cloud/vm/dao/UserVmJoinDao.java PRE-CREATION = > server/src/com/cloud/vm/dao/UserVmJoinDaoImpl.java PRE-CREATION = > server/test/com/cloud/api/APITest.java PRE-CREATION = > server/test/com/cloud/api/ListPerfTest.java PRE-CREATION = > server/test/com/cloud/api/LoginResponse.java PRE-CREATION = > server/test/com/cloud/keystore/KeystoreTest.java e0e2126 = > server/test/com/cloud/user/MockAccountManagerImpl.java 08234fd = > server/test/com/cloud/vm/MockUserVmManagerImpl.java 35ee139 = > setup/db/create-schema.sql acbbc41 = > utils/src/com/cloud/utils/db/GenericDaoBase.java 8d5cb96 = > = > Diff: https://reviews.apache.org/r/8172/diff/ > = > = > Testing > ------- > = > Create a performance unit test class to test the performance time. > = > = > Thanks, > = > Min Chen > = > --===============0984530796624313018==--