Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: cloudstack-dev@incubator.apache.org
Content-Type: multipart/alternative;
 boundary="===============2158683311658685452=="
MIME-Version: 1.0
Subject: Review Request: CLOUDSTACK-446: Host going to alert state,
 if you are adding already added host
From: "Koushik Das" <koushik.das@citrix.com>
To: "Abhinandan Prateek" <aprateek@apache.org>,
 "Alex Huang" <alex.huang@citrix.com>
Cc: "cloudstack" <cloudstack-dev@incubator.apache.org>,
 "Koushik Das" <koushik.das@citrix.com>
Date: Tue, 06 Nov 2012 06:41:10 -0000
Message-ID: <20121106064110.4790.72880@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: "Koushik Das" <noreply@reviews.apache.org>
Reply-To: "Koushik Das" <koushik.das@citrix.com>

--===============2158683311658685452==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7891/
-----------------------------------------------------------

Review request for cloudstack, Abhinandan Prateek and Alex Huang.


Description
-------

Adding an already added host fails with error but in the process incorrectl=
y updates the status of the host to 'Alert'. Have put a check to prevent th=
is.


Diffs
-----

  server/src/com/cloud/resource/ResourceManagerImpl.java ced601b =


Diff: https://reviews.apache.org/r/7891/diff/


Testing
-------

Steps to repro
1. Created a vmware cluster and added a host, verify that the status shows =
as 'Up'
2. Added the same host again, fails with error
3. Refresh the host page in MS UI to verify that host status chages to 'Ale=
rt' from 'Up'

After applying the fix follow the same repro steps and verify that the host=
 status doesn't change to 'Alert'.


Thanks,

Koushik Das


--===============2158683311658685452==--