incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasanna <...@apache.org>
Subject Re: Unit tests
Date Sat, 10 Nov 2012 15:11:39 GMT
On 10 November 2012 03:03, David Nalley <david@gnsa.us> wrote:
> On Fri, Nov 9, 2012 at 2:30 PM, Alex Huang <Alex.Huang@citrix.com> wrote:
>> +1  the more tests the merrier.
>>
>> I have noticed that in master doing mvn install actually runs some unit tests.  I
don't like that because it slows down compilation.  I haven't track down exactly what it is
but I think it's in the nicira plugin.
>>
>
> IMO (which isn't worth very much) running unit tests at compile is a
> good thing. It puts unit tests failures front and center to anyone
> working on the code and gets back to that idea of everyone being
> responsible for code quality. If a unit test is failing we have no
> business doing anything else until that is fixed. Currently these
> tests are only adding a few seconds to compile time in my limited
> tests. Additionally, if folks get into the habit of not running the
> tests on every compile they will never run the tests, and a failure
> will only come to light when jenkins runs the tests post-commit.
>
> If you really must not run the tests, you can always run -DskipTests=true

The current unittests are great to have. If we don't run them I feel
they will get abandoned later like it has happened before with
CloudStack. Many of the tests had to be resurrected to work against
the refactoring and changing of the build system for 4.0. Also, with
javelin work breaking down components it should not be hard to run
tests for the components that one affects/changes and not the entire
suite.

Mime
View raw message