incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hugo Trippaers" <htrippa...@schubergphilis.com>
Subject Re: Review Request: HttpClient needs releaseConnection method call
Date Thu, 22 Nov 2012 09:39:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8186/#review13691
-----------------------------------------------------------



plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java
<https://reviews.apache.org/r/8186/#comment29341>

    Can you release the connection here and still call the getStatusCode() below?



plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java
<https://reviews.apache.org/r/8186/#comment29342>

    Same here, the connnections is release before the statusCode is read.


- Hugo Trippaers


On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8186/
> -----------------------------------------------------------
> 
> (Updated Nov. 22, 2012, 8:42 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> Thanks to Hugo about pointing out the page http://hc.apache.org/httpclient-3.x/threading.html
, I found that we MUST call releaseConnection when we're using HttpClient in conjunction with
MultiThreadedHttpConnectionManager.
> 
> 
> Diffs
> -----
> 
>   agent/src/com/cloud/agent/AgentShell.java 774f222 
>   awsapi/src/com/cloud/bridge/io/S3CAStorBucketAdapter.java 2101afe 
>   plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java
26e7e0d 
>   server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 
>   server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 
> 
> Diff: https://reviews.apache.org/r/8186/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hiroaki Kawai
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message