incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanna Santhanam" <Prasanna.Santha...@citrix.com>
Subject Re: Review Request: some copy-paste cleanup
Date Mon, 12 Nov 2012 19:26:38 GMT


> On Nov. 12, 2012, 6:38 p.m., Prasanna Santhanam wrote:
> > Ship It!

Thanks for the patch. Please don't forget to close the review as submitted.


commit 1a67e3f5c64ae55ae022f0bc6640d2bda3511a1f
Author: Laszlo Hornyak <lhornyak@redhat.com>
Date:   Tue Nov 13 00:13:06 2012 +0530

    Summary: Extract redundant datasource code into method for Transaction.java
    
    Reviewed-by: Prasanna Santhanam <tsp@apache.org>
    Reported-by: Laszlo Hornyak <lhornyak@redhat.com>
    Signed-off-by: Prasanna Santhanam <tsp@apache.org> 1352745925 +0530


- Prasanna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8016/#review13359
-----------------------------------------------------------


On Nov. 12, 2012, 6:18 p.m., Laszlo Hornyak wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8016/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2012, 6:18 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> some copy-paste cleanup
> 
> 
> Diffs
> -----
> 
>   utils/src/com/cloud/utils/db/Transaction.java 7be9ee3 
> 
> Diff: https://reviews.apache.org/r/8016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Laszlo Hornyak
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message