incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Cahill" <dcah...@midokura.com>
Subject Review Request: Fix empty traffic labels causing NullPointerExceptions on KVM
Date Wed, 07 Nov 2012 07:31:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7923/
-----------------------------------------------------------

Review request for cloudstack, edison su and Marcus Sorensen.


Description
-------

In com.cloud.hypervisor.kvm.resource.BridgeVifDriver.java, in 2 places an if block should
have evaluated to true if trafficLabel was null, however it was causing a NullPointerException
instead.


Diffs
-----

  plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/BridgeVifDriver.java 116c09d


Diff: https://reviews.apache.org/r/7923/diff/


Testing
-------

Was running an Advanced Network with empty traffic labels, observed NullPointerExceptions.

Made change, deployed, NullPointerExceptions no longer experienced.


Thanks,

Dave Cahill


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message