incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Cahill" <dcah...@midokura.com>
Subject Review Request: Fix systemvm keypair setting in developer mode
Date Mon, 05 Nov 2012 02:31:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7861/
-----------------------------------------------------------

Review request for cloudstack and edison su.


Description
-------

When running as a user other than cloud, the systemvm keypairs were not being set, and no
warning was given, leading to errors later.

This patch:
* Sets the "developer" configuration key in the "developer" Maven pom.xml, so that developers
can run as any user
* Logs a WARN message that systemvm keypairs are not being set when users are running as a
user other than cloud and "developer" configuration key is not set 


Diffs
-----

  developer/developer-prefill.sql cba5382 
  server/src/com/cloud/server/ConfigurationServerImpl.java 904e8c5 

Diff: https://reviews.apache.org/r/7861/diff/


Testing
-------

>From blank environment, tested that:
* "mvn -P developer -pl developer -Ddeploydb" sets the developer configuration key
* systemvm keypairs get set correctly when running as a user other than cloud when "developer"
configuration key is set
* WARN message is logged on management server startup when running as a user other than cloud
and developer key is not set


Thanks,

Dave Cahill


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message