Return-Path: X-Original-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-cloudstack-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0997C9625 for ; Fri, 12 Oct 2012 21:22:26 +0000 (UTC) Received: (qmail 33648 invoked by uid 500); 12 Oct 2012 21:22:25 -0000 Delivered-To: apmail-incubator-cloudstack-dev-archive@incubator.apache.org Received: (qmail 33619 invoked by uid 500); 12 Oct 2012 21:22:25 -0000 Mailing-List: contact cloudstack-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cloudstack-dev@incubator.apache.org Delivered-To: mailing list cloudstack-dev@incubator.apache.org Received: (qmail 33606 invoked by uid 99); 12 Oct 2012 21:22:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Oct 2012 21:22:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id B10DA1C015C; Fri, 12 Oct 2012 21:22:23 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3633588142534180021==" MIME-Version: 1.0 Subject: Re: Review Request: re-add configure-info and sccs-info to cloud.spec From: "edison su" To: "Chip Childers" Cc: "Marcus Sorensen" , "edison su" , "cloudstack" Date: Fri, 12 Oct 2012 21:22:23 -0000 Message-ID: <20121012212223.19280.72734@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org Auto-Submitted: auto-generated Sender: "edison su" X-ReviewGroup: cloudstack X-ReviewRequest-URL: https://reviews.apache.org/r/7570/ X-Sender: "edison su" References: <20121012211633.19252.78402@reviews.apache.org> In-Reply-To: <20121012211633.19252.78402@reviews.apache.org> Reply-To: "edison su" --===============3633588142534180021== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7570/#review12407 ----------------------------------------------------------- Oops, David deliberately deletes sccs-info, as "waf rpm" doesn't work, if t= here is no git info in the source code. It breaks the rpm/deb build in our = release tar ball. David will comment out build_utils_docs in wscript_build,= then this issue will go away. - edison su On Oct. 12, 2012, 9:16 p.m., Marcus Sorensen wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7570/ > ----------------------------------------------------------- > = > (Updated Oct. 12, 2012, 9:16 p.m.) > = > = > Review request for cloudstack and Chip Childers. > = > = > Description > ------- > = > This fixes the git build. Does this break the tarball build? > = > = > This addresses bug CLOUDSTACK-329. > = > = > Diffs > ----- > = > cloud.spec 7e31edf = > = > Diff: https://reviews.apache.org/r/7570/diff/ > = > = > Testing > ------- > = > built fresh RPMs from current git repo code > = > = > Thanks, > = > Marcus Sorensen > = > --===============3633588142534180021==--