incubator-cloudstack-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Noah Slater <>
Subject Re: Rant: Request for better commit messages
Date Wed, 10 Oct 2012 18:50:13 GMT
Perhaps we could document this on the wiki, as part of a nascent coding
standards policy?

On Wed, Oct 10, 2012 at 8:01 AM, Rohit Yadav <> wrote:

> Hi folks,
> With due respect, I would like to request all the committers and
> contributors to write better commit message. [0]
> For example, a good commit message:
> A good commit message subject should have something like this with 80
> chars width:
> <Header line>: <short log description>
> <blank line>
> <body of commit message, explain things why, what, how, etc. giving
> background>
> <bulleted points help>
> <blank line>
> <Reported-by: if it's a bug>
> <Reviewed-by: if it was reviewed>
> <Signed-off: turn on signature in your .gitconfig>
> This is what we follow on;a=shortlogand they are
crazy about commits and patches, they just don't accept junk
> messages, even if code is fine. You may check, there is no or few reverts.
> When something breaks, I check all last commits and do a git log -p <file>
> to go through recent changes to a file, in case I think something broke I
> like to identify the changes that may have caused it instead of fixing it
> which may introduce further problems. I use tig and zsh to regularly follow
> commits and read commit messages.
> Also, please fix your editors and follow coding conventions.
> [0] (at the end)
> Regards.
> PS. I had to email about it as we're uncool with our git commit habits, we
> are doing triple or quadruple reverts, we need to fix our habits.


  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message